Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate common base.jl and solution.jl #1

Open
rb004f opened this issue Mar 5, 2018 · 4 comments
Open

Duplicate common base.jl and solution.jl #1

rb004f opened this issue Mar 5, 2018 · 4 comments

Comments

@rb004f
Copy link

rb004f commented Mar 5, 2018

GasModels.jl and PowerModels.jl has common code that should be duplicated here (and then removed from GasModels and PowerModels)

@rb004f
Copy link
Author

rb004f commented Mar 5, 2018

@ccoffrin This should probably be a staged approach

  1. Duplicate the code we think should be duplicated
  2. Write tests for that code (I am thinking we just have a simple flow model as the "Example" that lives in this package for testing and demonstration purposes).
  3. Register the package
  4. Remove the code from GasModels and PowerModels, and add InfrastructureModels as a REQUIRE

What do you think?

@ccoffrin
Copy link
Member

ccoffrin commented Mar 6, 2018

Agreed. This is the process I had in mind as well.

Writing meaningful tests can be tricky. In this package the test probably need to be a bit more rigorous to ensure the dependent packages don't break with updates are made.

@ccoffrin
Copy link
Member

ccoffrin commented Mar 6, 2018

I am a little hesitant to bring in the solution extraction code, as is, as this is something I have wanted to engineer for some time (lanl-ansi/PowerModels.jl#77).

@rb004f
Copy link
Author

rb004f commented Mar 6, 2018

Ok, then maybe the re-engineered solution extraction code should be implemented here, and GasModels and PowerModels will conform to the new one once it is ready.

kdheepak pushed a commit to kdheepak/InfrastructureModels.jl that referenced this issue Oct 15, 2018
kdheepak added a commit to kdheepak/InfrastructureModels.jl that referenced this issue Oct 15, 2018
This reverts commit 560ad09, reversing
changes made to 1614a0a.
ccoffrin pushed a commit that referenced this issue Oct 16, 2018
Revert "Merge pull request #1 from jd-lara/moi"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants