-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate common base.jl and solution.jl #1
Comments
@ccoffrin This should probably be a staged approach
What do you think? |
Agreed. This is the process I had in mind as well. Writing meaningful tests can be tricky. In this package the test probably need to be a bit more rigorous to ensure the dependent packages don't break with updates are made. |
I am a little hesitant to bring in the solution extraction code, as is, as this is something I have wanted to engineer for some time (lanl-ansi/PowerModels.jl#77). |
Ok, then maybe the re-engineered solution extraction code should be implemented here, and GasModels and PowerModels will conform to the new one once it is ready. |
Revert "Merge pull request #1 from jd-lara/moi"
GasModels.jl and PowerModels.jl has common code that should be duplicated here (and then removed from GasModels and PowerModels)
The text was updated successfully, but these errors were encountered: