Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-paragraph rules don't always work with command-line version #254

Closed
danielnaber opened this issue Apr 15, 2015 · 3 comments
Closed
Labels

Comments

@danielnaber
Copy link
Member

The error in this text (Delfin vs. Delphin) does not get detected when Main.runOnFileLineByLine() is used, but it works with runOnFileInOneGo():

Ein Test mit Delphin.

Ein anderer Absatz.

Hier noch ein Delfin.

Part of the problem is that JLanguageTool.getAllActiveRules() calls rule.reset(), which isn't clean anyway.

Also see this thread: http://www.mail-archive.com/[email protected]/msg04839.html

@danielnaber danielnaber changed the title cross-paragrpah rules don't always work with command-line version cross-paragraph rules don't always work with command-line version Apr 16, 2015
@danielnaber
Copy link
Member Author

Another issue caused by the different modes: http://forum.languagetool.org/t/wrong-fromx-and-tox-positions/738

danielnaber added a commit that referenced this issue Feb 20, 2016
@arysin
Copy link
Contributor

arysin commented Feb 22, 2016

Just a note that some change around this has made checking large files via
command-line very slow. At least for Ukrainian.
The file I have with ~610000 sentences that was taking ~6 min to check
before with latest code takes now more than an hour (and it's still not
finished). It's not about swapping as it uses only ~5G out of 24G I have.

@danielnaber
Copy link
Member Author

Marcin has already added a --line-by-line switch to re-activate the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants