Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http-request-executor): enhance file handling in HTTP requests #9944

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat(http-request-executor): enhance file handling in HTTP requests #9944

merged 2 commits into from
Oct 28, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Updated file mapping to include optional filename and MIME type.
  • Ensured compatibility with more complex file upload scenarios by supporting MIME type specification.
  • Defaulted MIME type to "application/octet-stream" when not provided.

Fixes #9599

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@laipz8200
feat(http-request-executor): enhance file handling in HTTP requests
32b8468 
- Updated file mapping to include optional filename and MIME type.
- Ensured compatibility with more complex file upload scenarios by supporting MIME type specification.
- Defaulted MIME type to "application/octet-stream" when not provided.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working 💪 enhancement New feature or request labels Oct 28, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@crazywoola crazywoola merged commit 4da0b70 into main Oct 28, 2024
9 checks passed
@crazywoola crazywoola deleted the fix/enhance-file-handling-in-HTTP-requests branch October 28, 2024 09:51
@laipz8200 laipz8200 mentioned this pull request Oct 28, 2024
Merged
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@laipz8200 @JunXu01
feat(http-request-executor): enhance file handling in HTTP requests (l…
9695011 
…anggenius#9944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working 💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Node seems losing meta data
2 participants
@laipz8200 @crazywoola