Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Vectorizer can be used in workflow #9932

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Oct 28, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

to support Vectorizer tool can run both in an agent app and a workflow app, changes:

  • change the Vectorizer tool's input can be a File type for workflow, or a string type for the agent
  • has file parameter's tool will not transfer to agent ---> has file parameter's tool and the parameter is required
  • when the tool transfer to agent, the File type parameter will be ignored
  • the download function of file can also download ToolFile and RemoteFile

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

test locally

  • Test workflow app
  • Test agent app

be7c9b7935f4afd50a9bb91958e3ade

2dee9a5c4243bc704a82bebfe167efc

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. labels Oct 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@crazywoola crazywoola merged commit ddb960d into langgenius:main Oct 28, 2024
6 checks passed
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. 🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants