Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]Ruff: lint errors for E731 #13018

Merged
merged 6 commits into from
Mar 5, 2025
Merged

[FIX]Ruff: lint errors for E731 #13018

merged 6 commits into from
Mar 5, 2025

Conversation

MikiPWata
Copy link
Contributor

@MikiPWata MikiPWata commented Jan 24, 2025 •
edited
Loading

Summary

removed ruff E731 from ignore inruff.toml and fixed the corresponding linter error

Screenshots

N/A

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@MikiPWata MikiPWata marked this pull request as ready for review January 24, 2025 09:10
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 24, 2025
@crazywoola crazywoola requested a review from laipz8200 January 24, 2025 10:42
@laipz8200 laipz8200 mentioned this pull request Jan 24, 2025
Open
3 tasks
@MikiPWata
Copy link
Contributor Author

Hi @laipz8200 !
I have fixed CI's format error. Can you give it anther try? thanks

@laipz8200
Copy link
Member

Hi @MikiPWata. Please sync your code with the main branch to fix the test.

@MikiPWata
Copy link
Contributor Author

@laipz8200
Done!

@laipz8200
Copy link
Member

laipz8200 commented Mar 3, 2025 •
edited
Loading

Hi, could you please resolve the conflicts?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 3, 2025
laipz8200
laipz8200 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 5, 2025
@laipz8200 laipz8200 merged commit 2e467cb into langgenius:main Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikiPWata @laipz8200