Update Elasticsearch spring implementation for 0.34 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new implementation expects to have an Elasticsearch Rest Client bean (recommended) or it will create it otherwise. This updates brings: * The support for the new way to implement the Elasticsearch embbeding store as we now pass a rest client instead of "just" properties (deprecated in langchain4j/langchain4j#712) * The removal of previously needed number of dimensions (deprecated in langchain4j/langchain4j#712) * We add a `checkSslCertificates` property which should be only used in tests. About tests: * We don't disable security anymore as it's not a good practice. We should educate users instead. * We don't wait anymore for 1s for documents to be available, but instead we call the refresh API to make the documents immediately visible. So we change the `awaitUntilPersisted()` method to `awaitUntilPersisted(ApplicationContext)` so we can fetch the Elasticsearch Rest Client bean. * We allow testing against a running cluster (local/cloud) and set from the CLI the URL (`ELASTICSEARCH_URL`), api key (`ELASTICSEARCH_API_KEY`), username (`ELASTICSEARCH_USERNAME`) and password (`ELASTICSEARCH_PASSWORD`). Note that when running with a self-signed certificate, the BASE64 version of the CA should be provided (`ELASTICSEARCH_CA_CERTIFICATE`). * We fetch the version of the cluster used to run the tests from the `pom.xml` file using `elastic.version` property. * We upgrade testcontainers to 1.20.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new implementation expects to have an Elasticsearch Rest Client bean (recommended) or it will create it otherwise.
This updates brings:
checkSslCertificatesproperty which should be only used in tests.caCertificateAsBase64Stringproperty which can be used in tests when using a self-signed certificate.About tests:
awaitUntilPersisted()method toawaitUntilPersisted(ApplicationContext)so we can fetch the Elasticsearch Rest Client bean.ELASTICSEARCH_URL), api key (ELASTICSEARCH_API_KEY), username (ELASTICSEARCH_USERNAME) and password (ELASTICSEARCH_PASSWORD). Note that when running with a self-signed certificate, the BASE64 version of the CA should be provided (ELASTICSEARCH_CA_CERTIFICATE).pom.xmlfile usingelastic.versionproperty.