New Baseline: Spring Boot 3 and Java 17 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@langchain4j what do you think? The tests are failing because the values from the environment variables are empty (e.g. the OpenAI API Key). I'm not sure why. |
|
@ThomasVitale thank you, looks good! |
|
Right, that makes sense. Next time, I'll create a branch directly from here instead of a fork. |
|
@ThomasVitale can't make it inject secrets from the fork :( I have run it locally, tests in anthropic are failing with This is probably due to |
|
@langchain4j I'll have a look, thanks |
|
It looks like the JUnit Pioneer dependency doesn't support running with Spring Boot 3 (junit-pioneer/junit-pioneer#810). I'll see if I can find some workaround. |
* Minimum supported version of Java is now 17 * Minimum supported version of Spring Boot is now 3.2 Spring Boot versions older than 3.2 reached EOL and will not receive any further support nor security patches. It would be a security risk to continue using EOL-ed versions in this LangChain4j project. More information: https://spring.io/projects/spring-boot#support Signed-off-by: Thomas Vitale <[email protected]>
ThomasVitale
force-pushed
the
baseline-spring-boot-3
branch
from
aa58c62 to
d069ea1
Compare
|
@langchain4j as agreed, I updated the PR removing the JUnit Pioneer extension. I couldn't reproduce the error on a Spring Boot app created from start.spring.io, so it's probably something specific to the project setup involving Maven SureFire, Java 17 and Spring Boot 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Boot versions older than 3.2 reached EOL and will not receive any further support nor security patches. It would be a security risk to continue using EOL-ed versions in this LangChain4j project.
More information: https://spring.io/projects/spring-boot#support