Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (google-common,vertex,etc): Support Claude 3.7 Thinking via Vertex AI #7793

Merged
merged 10 commits into from
Mar 5, 2025
Merged

feat (google-common,vertex,etc): Support Claude 3.7 Thinking via Vertex AI #7793

merged 10 commits into from
Mar 5, 2025

Conversation

afirstenberg
Copy link
Contributor

This adds direct support for Anthropic Claude 3.7 Thinking through Vertex AI

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 3, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 5, 2025 5:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Mar 5, 2025 5:31am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Mar 3, 2025
benjamincburns
benjamincburns requested changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@benjamincburns benjamincburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just ideally would need one relatively small addition to the tests.

@afirstenberg
Copy link
Contributor Author

Looks good overall, just ideally would need one relatively small addition to the tests.

I added two new tests to check for the ordering issue.
Along the way - I discovered a bug in how the tool response is sent and corrected that.

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Mar 5, 2025
@benjamincburns
Copy link
Collaborator

Looks great - thanks for keeping after this!

@benjamincburns benjamincburns merged commit 916e11c into langchain-ai:main Mar 5, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincburns benjamincburns benjamincburns approved these changes

Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afirstenberg @benjamincburns