Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs from initialize_agent into agent classmethod #799

Merged
merged 9 commits into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langchain/agents/initialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def initialize_agent(
)
agent_cls = AGENT_TO_CLASS[agent]
agent_obj = agent_cls.from_llm_and_tools(
llm, tools, callback_manager=callback_manager
llm, tools, callback_manager=callback_manager, **kwargs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the same kwargs also passed to the AgentExecutor though right? thats kind of an issue...

could we add another parameter that is agent_kwargs = Optional[dict] = None that we pass through here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

)
elif agent_path is not None:
agent_obj = load_agent(
Expand Down
27 changes: 27 additions & 0 deletions tests/unit_tests/agents/test_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,30 @@ def test_agent_tool_return_direct() -> None:

output = agent.run("when was langchain made")
assert output == "misalignment"


def test_agent_with_new_prefix_suffix() -> None:
"""Test agent initilization kwargs with new prefix and suffix."""
fake_llm = FakeListLLM(
responses=["FooBarBaz\nAction: Search\nAction Input: misalignment"]
)
tools = [
Tool("Search", lambda x: x, "Useful for searching", return_direct=True),
]
prefix = "FooBarBaz"

suffix = "Begin now!\nInput: {input}\nThought: {agent_scratchpad}"

agent = initialize_agent(
tools=tools,
llm=fake_llm,
agent="zero-shot-react-description",
prefix=prefix,
suffix=suffix,
)

# avoids "BasePromptTemplate" has no attribute "template" error
assert hasattr(agent.agent.llm_chain.prompt, "template")
prompt_str = agent.agent.llm_chain.prompt.template
assert prompt_str.startswith(prefix), "Prompt does not start with prefix"
assert prompt_str.endswith(suffix), "Prompt does not end with suffix"