Improve Error Message for failed callback #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-gan
reviewed
Jun 15, 2023
| except Exception as e: | ||
| if handler.raise_error: | ||
| raise e | ||
| logger.warning(f"Error in {event_name} callback: {e}") | ||
| logger.warning( |
There was a problem hiding this comment.
Just thinking. Maybe moving warning before if handler.raise_error: adds helpful information for debugging? Maybe raise e would provide enough debugging info. I'm not sure.
There was a problem hiding this comment.
Yeah that's a good point, especially if it's running on a separate thread. I'll make the change
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the handler class name in the warning