arxiv: Correct name of search client attribute to 'arxiv_search' from incorrect 'arxiv_client' #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ this private attribute is referenced as `arxiv_search` in internal usage and is set when verifying the environment
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
… incorrect 'arxiv_client' (langchain-ai#5917) + this private attribute is referenced as `arxiv_search` in internal usage and is set when verifying the environment twitter: @spazm #### Who can review? Any of @hwchase17, @leo-gan, or @bongsang might be interested in reviewing. + Mismatch between `arxiv_client` attribute vs `arxiv_search` in validation and usage is present in the initial commit by @hwchase17. + @leo-gan has made most of the edits. + @bongsang implemented pdf download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arxiv_searchin internal usage and is set when verifying the environmenttwitter: @spazm
Who can review?
Any of @hwchase17, @leo-gan, or @bongsang might be interested in reviewing.
arxiv_clientattribute vsarxiv_searchin validation and usage is present in the initial commit by @hwchase17.