Update MongoDBChatMessageHistory to create an index on SessionId #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the queries to the database are done based on the SessionId property, this will optimize how Mongo retrieves all messages from a session
hwchase17
reviewed
Jun 3, 2023
According to the docs:
I already use this in other projects (including dotnet ones), this just garantees the index exists, if it's already there Mongo will do nothing. From experience, the first times I used indexes in Mongo, I used to manually check from the application if that index already existed, but that just ends up being less optimal since there's more information going between Mongo and the application when it's just unecessary. |
hwchase17
approved these changes
Jun 4, 2023
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
…gchain-ai#5632) All the queries to the database are done based on the SessionId property, this will optimize how Mongo retrieves all messages from a session #### Who can review? Tag maintainers/contributors who might be interested: @dev2049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the queries to the database are done based on the SessionId property, this will optimize how Mongo retrieves all messages from a session
Who can review?
Tag maintainers/contributors who might be interested:
@dev2049