Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Anthropic LLM and Chat to be LangFlow friendly #5628

Closed
wants to merge 6 commits into from

Conversation

jimwhite
Copy link

@jimwhite jimwhite commented Jun 2, 2023

Change the Anthropic LLM and Chat classes to use model_name and default parameters the same way others do like OpenAI, Cohere, etc. Added an alias for model to model_name for backwards compatibility. By following the common pattern this will enable the Anthropic PR I'm working on for LangFlow (https://github.com/jimwhite/langflow/tree/anthropic) to work as expected.

Who can review?

Tag maintainers/contributors who might be interested:

Models

@jimwhite jimwhite marked this pull request as draft June 2, 2023 18:34
@jimwhite jimwhite marked this pull request as ready for review June 2, 2023 18:59
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@vercel
Copy link

vercel bot commented Jun 20, 2023

Someone is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@jimwhite
Copy link
Author

Friendly ping.

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 14, 2023
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 4:23am

@leo-gan
Copy link
Collaborator

leo-gan commented Sep 15, 2023

@jimwhite Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks!

@jimwhite
Copy link
Author

Actually I don't think this PR is needed anymore. After resolving the conflict I see the conflict was with another change doing the same thing with Field(... alias).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants