-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Anthropic LLM and Chat to be LangFlow friendly #5628
Conversation
…her than 'model').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks!
Someone is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Friendly ping. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jimwhite Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks! |
Actually I don't think this PR is needed anymore. After resolving the conflict I see the conflict was with another change doing the same thing with Field(... alias). |
Change the Anthropic LLM and Chat classes to use model_name and default parameters the same way others do like OpenAI, Cohere, etc. Added an alias for model to model_name for backwards compatibility. By following the common pattern this will enable the Anthropic PR I'm working on for LangFlow (https://github.com/jimwhite/langflow/tree/anthropic) to work as expected.
Who can review?
Tag maintainers/contributors who might be interested:
Models