Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docstring in faiss.py for load_local #5440

Merged
merged 1 commit into from
May 30, 2023

Conversation

luckyduck
Copy link
Contributor

Fix for docstring in faiss.py vectorstore (load_local)

The doctring should reflect that load_local loads something FROM the disk.

@dev2049

@dev2049
Copy link
Contributor

dev2049 commented May 30, 2023

thanks @luckyduck!

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 30, 2023
@dev2049 dev2049 merged commit 0d3a9d4 into langchain-ai:master May 30, 2023
vowelparrot pushed a commit that referenced this pull request May 31, 2023
# Fix for docstring in faiss.py vectorstore (load_local)

The doctring should reflect that load_local loads something FROM the
disk.
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Fix for docstring in faiss.py vectorstore (load_local)

The doctring should reflect that load_local loads something FROM the
disk.
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants