LLM wrapper for Databricks #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exc_info=True) | ||
| return context | ||
|
|
||
| def get_default_host(): |
There was a problem hiding this comment.
I will make a follow-up to create Databricks utility methods for getting the host and api_token.
mengxr
changed the title
mengxr
force-pushed
the
databricks-llm
branch
4 times, most recently
from
5d00c19 to
350db0f
Compare
|
LGTM except for some minor comments 👍 |
gengliangwang
approved these changes
May 24, 2023
Co-authored-by: Gengliang Wang <[email protected]>
Co-authored-by: Gengliang Wang <[email protected]>
dev2049
reviewed
May 24, 2023
dev2049
reviewed
May 24, 2023
mengxr
changed the title
|
@dev2049 I addressed your comments. This is ready for another pass. Thanks!! |
|
thanks @mengxr @gengliangwang! |
shitaoli-db
reviewed
Jun 1, 2023
| host = values["host"] | ||
| cluster_id = values["cluster_id"] | ||
| port = values["cluster_driver_port"] | ||
| api_url = f"https://{host}/driver-proxy-api/o/0/{cluster_id}/{port}" |
There was a problem hiding this comment.
@mengxr This might have a problem with the databricks driver proxy api with /o/0. The databricks repl context provided apiUrl is something like http://oregon.staging.databricks.com/. From my set up it seems that this does not work with the /o/0.
There was a problem hiding this comment.
This works fine with databricks notebook context's url address. Resolve now.
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
This PR adds LLM wrapper for Databricks. It supports two endpoint types: * serving endpoint * cluster driver proxy app An integration notebook is included to show how it works. Co-authored-by: Davis Chase <[email protected]> Co-authored-by: Gengliang Wang <[email protected]> Co-authored-by: Dev 2049 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LLM wrapper for Databricks. It supports two endpoint types:
An integration notebook is included to show how it works.
cc: @hwchase17 @agola11 @gengliangwang