Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solving #2887 #5127

Merged
merged 2 commits into from
May 23, 2023
Merged

solving #2887 #5127

merged 2 commits into from
May 23, 2023

Conversation

tommasodelorenzo
Copy link
Contributor

@tommasodelorenzo tommasodelorenzo commented May 23, 2023 •
edited
Loading

Allowing openAI fine-tuned models

Very simple fix that checks whether a openAI model_name is a fine-tuned model when loading context_size and when computing call's cost in the openai_callback.

Fixes #2887

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@hwchase17 @agola11

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 23, 2023
@dev2049
Copy link
Contributor

dev2049 commented May 23, 2023

thanks @tommasodelorenzo!

@dev2049 dev2049 merged commit 5002f3a into langchain-ai:master May 23, 2023
@tommasodelorenzo tommasodelorenzo mentioned this pull request May 23, 2023
Merged
vowelparrot pushed a commit that referenced this pull request May 24, 2023
@tommasodelorenzo @dev2049 @vowelparrot
solving #2887 (#5127)
76bac21 
# Allowing openAI fine-tuned models
Very simple fix that checks whether a openAI `model_name` is a
fine-tuned model when loading `context_size` and when computing call's
cost in the `openai_callback`.

Fixes #2887 
---------

Co-authored-by: Dev 2049 <[email protected]>
dev2049 added a commit that referenced this pull request May 24, 2023
@tommasodelorenzo @dev2049
fixing total cost finetuned model giving zero (#5144)
52714ce 
# OpanAI finetuned model giving zero tokens cost

Very simple fix to the previously committed solution to allowing
finetuned Openai models.

Improves #5127 

---------

Co-authored-by: Dev 2049 <[email protected]>
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@tommasodelorenzo @dev2049 @Undertone0809
fixing total cost finetuned model giving zero (langchain-ai#5144)
6d0b680 
# OpanAI finetuned model giving zero tokens cost

Very simple fix to the previously committed solution to allowing
finetuned Openai models.

Improves langchain-ai#5127 

---------

Co-authored-by: Dev 2049 <[email protected]>
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About fine tune model
2 participants
@tommasodelorenzo @dev2049