Improve pinecone hybrid search retriever adding metadata support #5098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve pinecone hybrid search retriever adding metadata support
I simply remove the hardwiring of metadata to the existing implementation allowing one to pass
metadatas
attribute to the constructors and inget_relevant_documents
. I also add one missing pip install to the accompanying notebook (I am not adding dependencies, they were pre-existing).First contribution, just hoping to help, feel free to critique :)
my twitter username is
@andreliebschner
While looking at hybrid search I noticed #3043 and #1743. I think the former can be closed as following the example right now (even prior to my improvements) works just fine, the latter I think can be also closed safely, maybe pointing out the relevant classes and example. Should I reply those issues mentioning someone?
@dev2049, @hwchase17