Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pinecone hybrid search retriever adding metadata support #5098

Merged

Conversation

lbsnrs
Copy link
Contributor

@lbsnrs lbsnrs commented May 22, 2023

Improve pinecone hybrid search retriever adding metadata support

I simply remove the hardwiring of metadata to the existing implementation allowing one to pass metadatas attribute to the constructors and in get_relevant_documents. I also add one missing pip install to the accompanying notebook (I am not adding dependencies, they were pre-existing).

First contribution, just hoping to help, feel free to critique :)
my twitter username is @andreliebschner

While looking at hybrid search I noticed #3043 and #1743. I think the former can be closed as following the example right now (even prior to my improvements) works just fine, the latter I think can be also closed safely, maybe pointing out the relevant classes and example. Should I reply those issues mentioning someone?

@dev2049, @hwchase17

@dev2049
Copy link
Contributor

dev2049 commented May 22, 2023

thanks @lbsnrs! looks good to me

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 22, 2023
@dev2049 dev2049 merged commit 44dc959 into langchain-ai:master May 22, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants