Chatconv agent: output parser exception #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blob42
changed the title
blob42
force-pushed
the
chatconv_parser_exception
branch
2 times, most recently
from
56ef889 to
0229e56
Compare
vowelparrot
reviewed
May 18, 2023
langchain/schema.py
Outdated
| @@ -360,7 +360,7 @@ def dict(self, **kwargs: Any) -> Dict: | |||
| return output_parser_dict | |||
|
|
|||
|
|
|||
| class OutputParserException(Exception): | |||
| class OutputParserException(ValueError, Exception): | |||
There was a problem hiding this comment.
What is this needed for?
There was a problem hiding this comment.
I added the ValueError as a base class to OutputParserException to avoid breaking code that was relying on ValueError as a way to catch exceptions from the agent. So catching ValuError still works. Not sure if this is a good idea ?
There was a problem hiding this comment.
good idea imo. but don't need to inherit from Exception in that case (ValueError already subclass of Exception)
There was a problem hiding this comment.
true didn't think about it.
blob42
force-pushed
the
chatconv_parser_exception
branch
from
0229e56 to
29c2de1
Compare
blob42
force-pushed
the
chatconv_parser_exception
branch
from
29c2de1 to
4e42c73
Compare
|
thanks @blob42 ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the output parser form chat conversational agent now raises
OutputParserExceptionlike the rest.The
raise OutputParserExeption(...) from eform also carries through the original error details on what went wrong.I added the
ValueErroras a base class toOutputParserExceptionto avoid breaking code that was relying onValueErroras a way to catch exceptions from the agent. So catching ValuError still works. Not sure if this is a good idea though ?Who can review?