Fix get_num_tokens for Anthropic models #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Anthropic classes used BaseLanguageModel.get_num_tokens because of an inheritance issue. We fix it by moving the method from _AnthropicCommon to both its subclasses.
|
good catch @jarib! |
|
Nice catch Jarib, thank you! And sorry I'm late to chiming in, but could we just reverse the order we list our superclasses to avoid the code duplication? |
|
Ah, maybe? I've not really used multiple inheritance much and wasn't sure if there was a reason for the order. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Anthropic classes used
BaseLanguageModel.get_num_tokensbecause of an issue with multiple inheritance. Fixed by moving the method from_AnthropicCommonto both its subclasses.This change will significantly speed up token counting for Anthropic users.
@agola11 @mikelambert