Harrison/faiss norm #4903
Merged
Harrison/faiss norm #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding normalization is to make sure the score returned is between 0 and 1. # Your PR Title (What it does) The PR fixes some score out of <0, 1> range issue in FAISS. The issue is #4086 <!-- Remove if not applicable --> Fixes #4086 ## Before submitting Finish the manual testing Before (with customized `score_normalizer`) ``` score : 68.8683853149414, result : 1.0 score : 74.28987121582031, result : 1.0 score : 77.00814056396484, result : 1.0 score : 79.08580017089844, result : 1.0 ``` After ``` score : 0.22136175632476807, result : 0.8434736010073924 score : 0.2508389353752136, result : 0.8226300878105723 score : 0.25133150815963745, result : 0.8222817862544782 score : 0.25269198417663574, result : 0.8213197844372171 ``` ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: Tools / Toolkits - @vowelparrot
hwchase17
added
the
lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.