Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny code review and docs fix for Docugami DataLoader #4877

Merged
merged 3 commits into from
May 17, 2023
Merged

Tiny code review and docs fix for Docugami DataLoader #4877

merged 3 commits into from
May 17, 2023

Conversation

tjaffri
Copy link
Contributor

@tjaffri tjaffri commented May 17, 2023

Docs and code review fixes for Docugami DataLoader

  1. I noticed a couple of hyperlinks that are not loading in the langchain docs (I guess need explicit anchor tags). Added those.
  2. In code review @eyurtsev had a suggestion to allow string paths. Turns out just updating the type works (I tested locally with string paths).

Pre-submission checks

I ran make lint and make tests successfully.

@tjaffri tjaffri marked this pull request as ready for review May 17, 2023 19:40
@dev2049
Copy link
Contributor

dev2049 commented May 17, 2023

thanks @tjaffri!

@dev2049 dev2049 merged commit ef8b5f6 into langchain-ai:master May 17, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
@tjaffri tjaffri deleted the tjaffri/docsfix branch September 17, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjaffri @dev2049