Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: compound ecosystem and integrations #4870

Merged
merged 6 commits into from
May 18, 2023
Merged

docs: compound ecosystem and integrations #4870

merged 6 commits into from
May 18, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented May 17, 2023

Docs: compound ecosystem and integrations

Problem statement: We have a big overlap between the References/Integrations and Ecosystem/LongChain Ecosystem pages. It confuses users. It creates a situation when new integration is added only on one of these pages, which creates even more confusion.

  • removed References/Integrations page (but move all its information into the individual integration pages - in the next PR).
  • renamed Ecosystem/LongChain Ecosystem into Integrations/Integrations. I like the Ecosystem term. It is more generic and semantically richer than the Integration term. But it mentally overloads users. The integration term is more concrete.
    UPDATE: after discussion, the Ecosystem is the term. Ecosystem/Integrations is the page (in place of Ecosystem/LongChain Ecosystem).

As a result, a user gets a single place to start with the individual integration.

Who can review?

@dev2049

@leo-gan leo-gan changed the title Docs: compound ecosystem and integrations docs: compound ecosystem and integrations May 17, 2023
@leo-gan leo-gan marked this pull request as ready for review May 17, 2023 18:09
@dev2049
Copy link
Contributor

dev2049 commented May 17, 2023

maybe im missing it but this doesn't seem to actually delete reference/integrations does it?

@leo-gan
Copy link
Collaborator Author

leo-gan commented May 18, 2023

maybe im missing it but this doesn't seem to actually delete reference/integrations does it?

Oops. Yeah, reference to the page is deleted but not the page. Removing this page. Thanks for mention it!

Copy link
Contributor

@dev2049 dev2049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple last comments, otherwise good to go!

docs/integrations.rst Outdated Show resolved Hide resolved
docs/integrations.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@leo-gan leo-gan requested a review from dev2049 May 18, 2023 04:03
@dev2049 dev2049 merged commit e2d7677 into langchain-ai:master May 18, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants