Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: text splitters improvements #4490

Merged
merged 4 commits into from
May 18, 2023
Merged

docs: text splitters improvements #4490

merged 4 commits into from
May 18, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented May 11, 2023

#docs: text splitters improvements

Changes are only in the Jupyter notebooks.

  • added links to the source packages and a short description of these packages
  • removed " Text Splitters" suffixes from the TOC elements (they made the list of the text splitters messy)
  • moved text splitters, based on the length function into a separate list. They can be mixed with any classes from the "Text Splitters", so it is a different classification.

Who can review?

    @hwchase17 - project lead
    @eyurtsev
    @vowelparrot

NOTE: please, check out the results of the Python code text splitter example (text_splitters/examples/python.ipynb). It looks suboptimal.

@leo-gan leo-gan marked this pull request as ready for review May 11, 2023 02:54
@leo-gan leo-gan marked this pull request as draft May 11, 2023 03:03
@leo-gan leo-gan marked this pull request as ready for review May 11, 2023 03:23
@leo-gan leo-gan marked this pull request as draft May 11, 2023 03:31
@leo-gan leo-gan marked this pull request as ready for review May 11, 2023 03:58
@leo-gan
Copy link
Collaborator Author

leo-gan commented May 16, 2023

@dev2049 Gentle remaining

Copy link
Contributor

@dev2049 dev2049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @leo-gan!

@leo-gan leo-gan requested a review from dev2049 May 17, 2023 18:36
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit c998569 into langchain-ai:master May 18, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants