Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AzureOpenAI embeddings documentation example. model -> deployment #4389

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix AzureOpenAI embeddings documentation example. model -> deployment #4389

merged 2 commits into from
May 18, 2023

Conversation

IsmaelGSerrano
Copy link
Contributor

Documentation for Azure OpenAI embeddings model

  • OPENAI_API_VERSION environment variable is needed for the endpoint
  • The constructor does not work with model, it works with deployment.

I fixed it in the notebook.

(This is my first contribution)

Who can review?

@hwchase17
@agola

@hwchase17 hwchase17 merged commit 41e2394 into langchain-ai:master May 18, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsmaelGSerrano @hwchase17