Fix temperature parameter will not be consider for reasoning models community/llms/openai.py #29551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅Added testcases to validate tests/unit_tests/graphs/test_age_graph.py
…ing models as reasoning models does not support temeperature parameter
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
rawathemant246
changed the title
ccurme
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Thanks for this.
The community implementation of ChatOpenAI is deprecated-- you should be seeing warnings directing you to the langchain-openai implementation. This implementation has a null default temperature.
I think if a user passes in:
llm = ChatOpenAI(model="o1", temperature=0)It is reasonable to pass this through to openai and raise an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temperatureparameter. Attempting to set it results in aBadRequestError. This commit modifies the ChatOPENAI api will not consider temperature parameter for reasoning models.Additional guidelines:
communitypackage.