text-splitters[patch]: delete unused html_chunks_with_headers.xslt #29340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: text splitters
AhmedTammaa
force-pushed
the
html-splitter-cleaning
branch
from
aafba64 to
4b9dd4c
Compare
|
Hey @eyurtsev, This is a follow-up for PR #267678. I just removed the unused file for code cleaning. I will do the suggested simplification in a different PR to keep things simple. |
ccurme
approved these changes
Jan 23, 2025
dosubot
bot
added
the
lgtm
ccurme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the now-unused html_chunks_with_headers.xslt file from the codebase. In a previous update (PR #27678), the HTMLHeaderTextSplitter class was refactored to utilize BeautifulSoup instead of lxml and XSLT for HTML processing. As a result, the html_chunks_with_headers.xslt file is no longer necessary and can be safely deleted to maintain code cleanliness and reduce potential confusion.
Issue: N/A
Dependencies: N/A