Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai[patch]: fix missing f-string modifier in oai structured output parsing error #29326

Merged

Conversation

Drummersbrother
Copy link
Contributor

  • Description: The ValueError raised on certain structured-outputs parsing errors, in langchain openai community integration, was missing a f-string modifier and so didn't produce useful outputs. This is a 2-line, 2-character change.

  • Issue: None open that this fixes

  • Dependencies: Nothing changed

  • Twitter handle: None

  • Add tests and docs: There's nothing to add for.

  • [-] Lint and test: Happy to run this if you deem it necessary.

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 2:22pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. langchain Related to the langchain package 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jan 21, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 21, 2025
@ccurme ccurme changed the title Community: fix missing f-string modifier in oai structured output parsing error openai[patch]: fix missing f-string modifier in oai structured output parsing error Jan 21, 2025
@ccurme ccurme enabled auto-merge (squash) January 21, 2025 14:22
@ccurme ccurme merged commit 32c9c58 into langchain-ai:master Jan 21, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants