-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPEX models support #29179
Add IPEX models support #29179
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey there! I believe this has come up before, and I think @Jofthomas on the huggingface side had a preference for having some separate packages for openvino (e.g. langchain-openvino or langchain-huggingface-openvino) and ipex
I see your profile indicates you work at huggingface - we have a shared slack channel with you that you could join if you want to discuss!
Hi @efriis, thanks for the rapid update! Yes I believe @Jofthomas is planning to work on a refactorization, in the meantime I opened this PR to add IPEX support (+ simplifying the current code a bit as well), let me know if that works for you or if you'd like to wait for the refactorization before adding anything else cc @Jofthomas |
Thanks ! The PR LGTM @echarlaix 👍 @efriis, It has been decided otherwise in the meantime. We will indeed enable Intel backend in the HF pipeline directly in this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @echarlaix for this PR.
Seems good to merge @efriis
@efriis let me know if you need any additional modifications |
sounds good thanks! |
Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/ |
Add IPEX support to
HuggingFacePipeline