partners: update pinecone client #28320
Open
+991
−829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aulorbe
commented
Nov 23, 2024
Comment on lines
+26
to
+28
| numpy = [ | ||
| { version = "^1", python = "<3.12" }, | ||
| { version = "^1.26.0", python = ">=3.12" } |
There was a problem hiding this comment.
Just a structural change to make things cleaner
jhamon
approved these changes
Nov 25, 2024
| @@ -74,6 +74,7 @@ class PineconeVectorStore(VectorStore): | |||
| dimension=1536, | |||
| metric="cosine", | |||
| spec=ServerlessSpec(cloud="aws", region="us-east-1"), | |||
| deletion_protection="disabled", # Defaults to "enabled" | |||
There was a problem hiding this comment.
The default behavior is deletion_protection="disabled" So this comment is incorrect.
| @@ -21,15 +21,12 @@ disallow_untyped_defs = "True" | |||
| [tool.poetry.dependencies] | |||
| python = ">=3.9,<3.13" | |||
| langchain-core = "^0.3.15" | |||
| pinecone-client = "^5.0.0" | |||
| pinecone = ">=5.4.0" | |||
There was a problem hiding this comment.
This should be "^5.4.0". >=5.4.0 would include future breaking changes which may not be compatible.
Poetry docs have a nice explanation of how these various syntax elements in version numbers are interpreted. https://python-poetry.org/docs/dependency-specification/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Pinecone client to
5.4.0, as well as its dependencies (pinecone-plugin-inferenceandpinecone-plugin-interface).Note:
pinecone-clientis now simply calledpinecone.Question for reviewer(s): should this PR also update the
pineconedep in the root dir'spoetry.lockfile? Was unsure.--
TW: @audrey_sage_