Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: ✨ Use new OVHcloud batch embedding #26209

Merged
merged 7 commits into from
Nov 4, 2024
Merged

community: ✨ Use new OVHcloud batch embedding #26209

merged 7 commits into from
Nov 4, 2024

Conversation

philippart-s
Copy link
Contributor

  • Description: change to do the batch embedding server side and not client side
  • Twitter handle: @wildagsx

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:38pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. community Related to langchain-community Ɑ: embeddings Related to text embedding models module labels Sep 9, 2024
@langcarl
Copy link

langcarl bot commented Nov 4, 2024

Thank you for the PR. This PR is marked Needs Support and has not yet received the 5 upvotes required by maintainers for review. It has been open for at least 25 days. Per the LangChain review process, this PR will be closed in 5 days if it does not reach the required threshold.

The Needs Support status is intended to prioritize review time on features that have demonstrated community support. If you feel this status was assigned in error or need more time to gather the required upvotes, please ping @ccurme and @efriis.

@langcarl langcarl bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2024
@philippart-s
Copy link
Contributor Author

👋 @ccurme / @efriis : I'm note sure ti understand what I have to do?

@ccurme ccurme self-assigned this Nov 4, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 4, 2024
@ccurme ccurme merged commit 4b8cd7a into langchain-ai:master Nov 4, 2024
18 checks passed
@ccurme
Copy link
Collaborator

ccurme commented Nov 4, 2024

Hi @philippart-s. If a PR is given a status of Needs Support (see Status in right-hand sidebar), the request is that authors demonstrate community demand via reactions on the PR.

In this case I see you are affiliated with OVHcloud, and this is quick to review, so I've updated the status to review and merged it in.

shjunn pushed a commit to shjunn/langchain that referenced this pull request Nov 4, 2024
@philippart-s @ccurme @shjunn
community: ✨ Use new OVHcloud batch embedding (langchain-ai#26209)
c7dc8b7 
- **Description:** change to do the batch embedding server side and not
client side
- **Twitter handle:** @wildagsx

---------

Co-authored-by: ccurme <[email protected]>
@philippart-s
Copy link
Contributor Author

thanks @ccurme 😊

yanomaly pushed a commit to yanomaly/langchain that referenced this pull request Nov 8, 2024
@philippart-s @ccurme @yanomaly
community: ✨ Use new OVHcloud batch embedding (langchain-ai#26209)
1dccc90 
- **Description:** change to do the batch embedding server side and not
client side
- **Twitter handle:** @wildagsx

---------

Co-authored-by: ccurme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees

@ccurme ccurme

Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippart-s @ccurme