Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ollama doc update (toolcalling, install, notebook examples) #25549

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

BobMerkus
Copy link
Contributor

The new langchain-ollama package seems pretty well implemented, but I noticed the docs were still outdated so I decided to fix em up a bit.

Problem: Docs note langchain-community instead of langchain-ollama

Solution: Update docs to https://python.langchain.com/v0.2/docs/integrations/chat/ollama/

Problem: OllamaFunctions is deprecated, as noted on Integrations: This was an experimental wrapper that attempts to bolt-on tool calling support to models that do not natively support it. The primary Ollama integration now supports tool calling, and should be used instead.

Solution: Delete old notebook from repo, update the existing one with @tool decorator + pydantic examples to the notebook

Problem: Llama3.1 was released while llama3-groq-tool-call fine-tune Is noted in notebooks.

Solution: update docs + notebooks to llama3.1 (which has improved tool calling support)

Problem: Install instructions are incomplete, there is no information to download a model and/or run the Ollama server

Solution: Add simple instructions to start the ollama service and pull model (for toolcalling)

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 19, 2024
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:16pm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Aug 19, 2024
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 20, 2024
@ccurme ccurme merged commit 8e3e532 into langchain-ai:master Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants