Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: vector store integration pages #24858

Merged
merged 21 commits into from
Aug 6, 2024
Merged

[docs]: vector store integration pages #24858

merged 21 commits into from
Aug 6, 2024

Conversation

isahers1
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 5:20pm

@isahers1 isahers1 changed the title [docs]: vector store table [docs]: vector store integration pages Aug 1, 2024
@efriis efriis added the partner label Aug 5, 2024
@efriis efriis self-assigned this Aug 5, 2024
@isahers1 isahers1 marked this pull request as ready for review August 5, 2024 23:39
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module labels Aug 5, 2024
@dosubot dosubot bot added 🔌: astradb Primarily related to AstraDB integrations 🔌: chroma Primarily related to ChromaDB integrations 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations 🔌: milvus Primarily related to Milvus vector store integration 🔌: pinecone Primarily related to Pinecone vector store integration 🔌: qdrant Primarily related to Qdrant vector store integration 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Aug 5, 2024
efriis
efriis approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit otherwise lgtm

docs/docs/integrations/vectorstores/faiss_index/index.faiss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to commit this or remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove I think, it was leftover from a previous PR. unless I'm missing something it's just a file generated when you run the notebook

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice added a .gitignore so it doesn't get committed back

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 6, 2024
@efriis efriis enabled auto-merge (squash) August 6, 2024 17:08
@efriis efriis merged commit a72fddb into master Aug 6, 2024
85 checks passed
@efriis efriis deleted the isaac/vectorstoretable branch August 6, 2024 17:20
@ccurme ccurme mentioned this pull request Aug 7, 2024
Merged
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
@isahers1 @efriis @olgamurraft
[docs]: vector store integration pages (langchain-ai#24858)
92b706d 
Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🔌: astradb Primarily related to AstraDB integrations 🔌: chroma Primarily related to ChromaDB integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: milvus Primarily related to Milvus vector store integration partner 🔌: pinecone Primarily related to Pinecone vector store integration 🔌: qdrant Primarily related to Qdrant vector store integration size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isahers1 @efriis