couchbase: Add the initial version of Couchbase partner package #22087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: vector store
efriis
reviewed
Jun 5, 2024
There was a problem hiding this comment.
2 things (sorry if duplicate - github UI glitched out when submitting at first)
- all
from couchbase.* importlines should be at the top of the file because it's a required dep! - all default implementations of functions (that can be gotten from
VectorStoresuperclass) should be deleted
| Set to True by default. | ||
| """ | ||
| try: | ||
| from couchbase.cluster import Cluster |
There was a problem hiding this comment.
convert to top-of-file import since it's a required dep of package
There was a problem hiding this comment.
Have fixed it in 50e4a89
Comment on lines
435
to
437
| import couchbase.search as search | ||
| from couchbase.options import SearchOptions | ||
| from couchbase.vector_search import VectorQuery, VectorSearch |
| ) | ||
| return [doc for doc, _ in docs_with_scores] | ||
|
|
||
| async def asimilarity_search( |
There was a problem hiding this comment.
delete all default implementations that can be gotten from superclass
There was a problem hiding this comment.
Have fixed it in 4d4ade5
efriis
approved these changes
Jun 7, 2024
dosubot
bot
added
the
lgtm
efriis
changed the title
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Nithish Raghunandanan <[email protected]> Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.