Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docstring for Runnable bind method #19659

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jhicks2306
Copy link
Contributor

Added example to the docstring of the "bind" method of Runnable. This makes it easier to understand the purpose of the method when reviewing in code editors. E.g. VS Code below.

Screenshot 2024-03-27 at 16 24 18

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 5:58pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: Runnables Related to Runnables 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 27, 2024
@ccurme ccurme self-assigned this Mar 27, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2024
@ccurme
Copy link
Collaborator

ccurme commented Mar 27, 2024

Looks great!

Screenshot 2024-03-27 at 1 55 36 PM

^ Linter was upset by a trailing whitespace. Running make format from the package root can fix.

@ccurme ccurme merged commit bcb8ab5 into langchain-ai:master Mar 27, 2024
95 checks passed
@jhicks2306
Copy link
Contributor Author

Ok. Thanks for the pointer on make format @ccurme!

@jhicks2306 jhicks2306 deleted the bind-docstr branch March 27, 2024 18:25
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Added example to the docstring of the "bind" method of Runnable. This
makes it easier to understand the purpose of the method when reviewing
in code editors. E.g. VS Code below.

<img width="833" alt="Screenshot 2024-03-27 at 16 24 18"
src="https://github.com/langchain-ai/langchain/assets/45722942/ad022d4e-7bc0-4f4b-aa7a-838f1816cc52">

---------

Co-authored-by: Chester Curme <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
Added example to the docstring of the "bind" method of Runnable. This
makes it easier to understand the purpose of the method when reviewing
in code editors. E.g. VS Code below.

<img width="833" alt="Screenshot 2024-03-27 at 16 24 18"
src="https://github.com/langchain-ai/langchain/assets/45722942/ad022d4e-7bc0-4f4b-aa7a-838f1816cc52">

---------

Co-authored-by: Chester Curme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: Runnables Related to Runnables size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants