Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Update doc-strings for text2vec embeddings #19657

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

hulitaitai
Copy link
Contributor

Add that URL of the embedding tool "text2vec".
Fix minor mistakes in the doc-string.

Add that URL of the embedding tool "text2vec".
Fix minor mistakes in the doc-string.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 27, 2024
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 4:09pm

@dosubot dosubot bot added Ɑ: embeddings Related to text embedding models module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 27, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2024
@eyurtsev
Copy link
Collaborator

Thank you for following up with another PR @hulitaitai

@eyurtsev eyurtsev merged commit dc2c9dd into langchain-ai:master Mar 27, 2024
58 checks passed
@eyurtsev eyurtsev changed the title Update text2vec.py community[patch]: Update doc-strings for text2vec embeddings Mar 27, 2024
@eyurtsev
Copy link
Collaborator

@hulitaitai if you can try to improve the commit titles -- it'll make it easier for other developers to understand what changes happened (most developers won't know what text2vec.py is)

@hulitaitai
Copy link
Contributor Author

@hulitaitai if you can try to improve the commit titles -- it'll make it easier for other developers to understand what changes happened (most developers won't know what text2vec.py is)

I am so thankful. I learnt so much with you.

gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Add that URL of the embedding tool "text2vec".
Fix minor mistakes in the doc-string.
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
Add that URL of the embedding tool "text2vec".
Fix minor mistakes in the doc-string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants