Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix broken imports in documentation #19655

Merged
merged 3 commits into from
Mar 27, 2024
Merged

docs: Fix broken imports in documentation #19655

merged 3 commits into from
Mar 27, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Mar 27, 2024

Found via script in #19611

Only ones remaining are:

File: docs/docs/integrations/tools/google_drive.ipynb
    langchain_community.tools.google_drive.tool.GoogleDriveSearchTool
    langchain_community.utilities.google_drive.GoogleDriveAPIWrapper

But I can't find these objects in the Langchain repo or in https://github.com/langchain-ai/langchain-google/ (cc @efriis)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 27, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:52pm

@dosubot dosubot bot added 🔌: google Primarily related to Google GenAI or VertexAI integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 27, 2024
@baskaryan
Copy link
Collaborator

those google drive imports are supposed to be

langchain_googldrive.tools.google_drive.tool.GoogleDriveSearchTool
langchain_googledrive.utilities.google_drive.GoogleDriveAPIWrapper

but i think at some point we messed them up. see #9999 for original notebook

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2024
@ccurme ccurme merged commit 4e9b358 into master Mar 27, 2024
11 checks passed
@ccurme ccurme deleted the cc/fix_doc_imports branch March 27, 2024 17:54
@ccurme ccurme mentioned this pull request Mar 27, 2024
Merged
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@ccurme @gkorland
docs: Fix broken imports in documentation (langchain-ai#19655)
bd395cf 
Found via script in langchain-ai#19611
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@ccurme @hinthornw
docs: Fix broken imports in documentation (#19655)
a0c0221 
Found via script in #19611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🔌: google Primarily related to Google GenAI or VertexAI integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccurme @baskaryan @eyurtsev