Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: XMLOutputParser fix to handle changes to xml standard library #19612

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

eyurtsev
Copy link
Collaborator

Newest python micro releases broke streaming in the XMLOutputParser. This fixes
the parsing code to work with trailing junk after the XML content.

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 9:09pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: parsing Related to output parser module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 26, 2024
@eyurtsev eyurtsev requested a review from nfcampos March 26, 2024 21:19
@eyurtsev eyurtsev merged commit 8ab7bb3 into master Mar 27, 2024
95 checks passed
@eyurtsev eyurtsev deleted the eugene/fix_for_newer_master branch March 27, 2024 13:25
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…brary (langchain-ai#19612)

Newest python micro releases broke streaming in the XMLOutputParser. This fixes the parsing code to work with trailing junk after the XML content.
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…brary (#19612)

Newest python micro releases broke streaming in the XMLOutputParser. This fixes the parsing code to work with trailing junk after the XML content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: parsing Related to output parser module size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants