langchain[major]: Use InMemoryVectorStore by default in VectorstoreIndexCreator #19575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
eyurtsev
changed the title
eyurtsev
approved these changes
Mar 26, 2024
dosubot
bot
added
the
lgtm
|
@baskaryan I am in favor of this. This will allow us to move some of these abstractions to langchain-core longer term (once we get rid of numpy depdency for the memory vectorstore). Can i get a second 👍 for the breaking change? |
|
Got 👍 from @hinthornw |
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…dexCreator (langchain-ai#19575) This is a small breaking change but I think it should be done as: * No external dependency needs to be installed anymore for the default to work * It is vendor-neutral
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…dexCreator (#19575) This is a small breaking change but I think it should be done as: * No external dependency needs to be installed anymore for the default to work * It is vendor-neutral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small breaking change but I think it should be done as: