Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain_openai: fix ChatOpenAI model's openai proxy #19559

Merged
merged 8 commits into from
Mar 28, 2024
Merged

langchain_openai: fix ChatOpenAI model's openai proxy #19559

merged 8 commits into from
Mar 28, 2024

Conversation

Sukitly
Copy link
Contributor

@Sukitly Sukitly commented Mar 26, 2024

Due to changes in the OpenAI SDK, the previous method of setting the OpenAI proxy in ChatOpenAI no longer works. This PR fixes this issue, making the previous way of setting the OpenAI proxy in ChatOpenAI effective again.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 26, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 5:26am

@dosubot dosubot bot added 🔌: openai Primarily related to OpenAI integrations 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 26, 2024
@eyurtsev
Copy link
Collaborator

@efriis / @baskaryan , are we ready to mark the community version of the model as @deprecated?

@Sukitly thanks for the contribution -- i think @efriis / @baskaryan have a bit more insight on the integration. Generally we recommend to all users to swap to langchain_openai which is the dedicated package for the open ai integration. The version in langchain community will be deprecated at some point in the future and we will stop accepting PRs for it

@baskaryan
Copy link
Collaborator

@efriis / @baskaryan , are we ready to mark the community version of the model as @deprecated?

@Sukitly thanks for the contribution -- i think @efriis / @baskaryan have a bit more insight on the integration. Generally we recommend to all users to swap to langchain_openai which is the dedicated package for the open ai integration. The version in langchain community will be deprecated at some point in the future and we will stop accepting PRs for it

@eyurtsev it is marked as deprecated, any updates should be to langchain_openai.chat_models.ChatOpenAI

@baskaryan baskaryan added the needs work PRs that need more work label Mar 26, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 27, 2024
@efriis efriis added the partner label Mar 27, 2024
@efriis efriis self-assigned this Mar 27, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@Sukitly Sukitly changed the title comunity: fix ChatOpenAI model's openai proxy langchain_openai: fix ChatOpenAI model's openai proxy Mar 27, 2024
@Sukitly
Copy link
Contributor Author

Sukitly commented Mar 27, 2024

@baskaryan @efriis
I moved the changes to langchain_openai.chat_models.ChatOpenAI.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2024
@baskaryan baskaryan merged commit 332996b into langchain-ai:master Mar 28, 2024
20 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@Sukitly @baskaryan @gkorland
openai[patch]: fix ChatOpenAI model's openai proxy (langchain-ai#19559)
1dbcad8 
Due to changes in the OpenAI SDK, the previous method of setting the
OpenAI proxy in ChatOpenAI no longer works. This PR fixes this issue,
making the previous way of setting the OpenAI proxy in ChatOpenAI
effective again.

---------

Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@Sukitly @baskaryan @hinthornw
openai[patch]: fix ChatOpenAI model's openai proxy (#19559)
cde9dc2 
Due to changes in the OpenAI SDK, the previous method of setting the
OpenAI proxy in ChatOpenAI no longer works. This PR fixes this issue,
making the previous way of setting the OpenAI proxy in ChatOpenAI
effective again.

---------

Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees

@efriis efriis

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. needs work PRs that need more work 🔌: openai Primarily related to OpenAI integrations partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sukitly @eyurtsev @baskaryan @efriis