Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add VDMS vectorstore #19551

Merged
merged 66 commits into from
Mar 28, 2024
Merged

Conversation

cwlacewe
Copy link
Contributor

  • Description: Add support for Intel Lab's Visual Data Management System (VDMS) as a vector store
  • Dependencies: vdms library which requires protobuf = "4.24.2". There is a conflict with dashvector in langchain package but conflict is resolved in community.
  • Contribution maintainer: @cwlacewe
  • Added tests: libs/community/tests/integration_tests/vectorstores/test_vdms.py
  • Added docs: docs/docs/integrations/vectorstores/vdms.ipynb
  • Added cookbook: cookbook/multi_modal_RAG_vdms.ipynb

revert whitespaces
revert whitespaces
revert whitespaces
revert whitespaces
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 26, 2024
@cwlacewe
Copy link
Contributor Author

@baskaryan I noticed the checks regarding tests fail due to importing vdms. Do I need to make any updates to the poetry files?

@cwlacewe
Copy link
Contributor Author

@eyurtsev @baskaryan,
Can someone point me to information on how to properly add vdms to the poetry files so it can be imported for the tests? I followed instructions provided in https://python.langchain.com/docs/contributing/code#working-with-optional-dependencies and also https://python.langchain.com/docs/contributing/testing#prepare but all CIs are still failing. Am I missing something?

@baskaryan baskaryan enabled auto-merge (squash) March 27, 2024 22:23
@baskaryan baskaryan merged commit a31f692 into langchain-ai:master Mar 28, 2024
61 checks passed
@cwlacewe cwlacewe deleted the add_vdms branch March 28, 2024 04:52
@cwlacewe cwlacewe restored the add_vdms branch March 28, 2024 04:54
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
- **Description:** Add support for Intel Lab's [Visual Data Management
System (VDMS)](https://github.com/IntelLabs/vdms) as a vector store
- **Dependencies:** `vdms` library which requires protobuf = "4.24.2".
There is a conflict with dashvector in `langchain` package but conflict
is resolved in `community`.
- **Contribution maintainer:** [@cwlacewe](https://github.com/cwlacewe)
- **Added tests:**
libs/community/tests/integration_tests/vectorstores/test_vdms.py
- **Added docs:** docs/docs/integrations/vectorstores/vdms.ipynb
- **Added cookbook:** cookbook/multi_modal_RAG_vdms.ipynb

---------

Co-authored-by: Eugene Yurtsev <[email protected]>
Co-authored-by: Bagatur <[email protected]>
Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
- **Description:** Add support for Intel Lab's [Visual Data Management
System (VDMS)](https://github.com/IntelLabs/vdms) as a vector store
- **Dependencies:** `vdms` library which requires protobuf = "4.24.2".
There is a conflict with dashvector in `langchain` package but conflict
is resolved in `community`.
- **Contribution maintainer:** [@cwlacewe](https://github.com/cwlacewe)
- **Added tests:**
libs/community/tests/integration_tests/vectorstores/test_vdms.py
- **Added docs:** docs/docs/integrations/vectorstores/vdms.ipynb
- **Added cookbook:** cookbook/multi_modal_RAG_vdms.ipynb

---------

Co-authored-by: Eugene Yurtsev <[email protected]>
Co-authored-by: Bagatur <[email protected]>
Co-authored-by: Bagatur <[email protected]>
@cwlacewe cwlacewe deleted the add_vdms branch July 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants