Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cohere[patch]: Add additional kwargs support for Cohere SDK params #19533

Merged

Conversation

giannis2two
Copy link
Contributor

  • Adds support for additional_kwargs in get_cohere_chat_request
    • This functionality passes in Cohere SDK specific parameters from BaseMessage based classes to the API

@efriis efriis added the partner label Mar 25, 2024
@efriis efriis self-assigned this Mar 25, 2024
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 6:29pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔌: cohere Primarily related to Cohere integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 25, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
@giannis2two giannis2two force-pushed the giannis/cohere-additional-kwargs branch from 6d03e8e to e4bd754 Compare March 26, 2024 16:39
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 26, 2024
@efriis efriis changed the title langchain_cohere: Add additional kwargs support for Cohere SDK params cohere[patch]: Add additional kwargs support for Cohere SDK params Mar 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
@efriis efriis enabled auto-merge (squash) March 26, 2024 18:28
@efriis efriis merged commit 9ea2a9b into langchain-ai:master Mar 26, 2024
20 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…angchain-ai#19533)

* Adds support for `additional_kwargs` in `get_cohere_chat_request`
* This functionality passes in Cohere SDK specific parameters from
`BaseMessage` based classes to the API

---------

Co-authored-by: Erick Friis <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…19533)

* Adds support for `additional_kwargs` in `get_cohere_chat_request`
* This functionality passes in Cohere SDK specific parameters from
`BaseMessage` based classes to the API

---------

Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: cohere Primarily related to Cohere integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants