-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cohere[patch]: Add additional kwargs support for Cohere SDK params #19533
Merged
efriis
merged 10 commits into
langchain-ai:master
from
giannis2two:giannis/cohere-additional-kwargs
Mar 26, 2024
Merged
cohere[patch]: Add additional kwargs support for Cohere SDK params #19533
efriis
merged 10 commits into
langchain-ai:master
from
giannis2two:giannis/cohere-additional-kwargs
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
harry-cohere
approved these changes
Mar 25, 2024
6d03e8e
to
e4bd754
Compare
giannis2two
commented
Mar 26, 2024
efriis
approved these changes
Mar 26, 2024
efriis
reviewed
Mar 26, 2024
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…angchain-ai#19533) * Adds support for `additional_kwargs` in `get_cohere_chat_request` * This functionality passes in Cohere SDK specific parameters from `BaseMessage` based classes to the API --------- Co-authored-by: Erick Friis <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…19533) * Adds support for `additional_kwargs` in `get_cohere_chat_request` * This functionality passes in Cohere SDK specific parameters from `BaseMessage` based classes to the API --------- Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔌: cohere
Primarily related to Cohere integrations
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
partner
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional_kwargs
inget_cohere_chat_request
BaseMessage
based classes to the API