Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: fix xml output parser transform #19530

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Mar 25, 2024

Previous PR passed _parser attribute which apparently is not meant to be used by user code and causes non deterministic failures on CI when testing the transform and a transform methods. Reverting this change temporarily.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 9:29pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🔌: openai Primarily related to OpenAI integrations 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 25, 2024
@eyurtsev eyurtsev requested a review from baskaryan March 25, 2024 20:53
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@eyurtsev
Copy link
Collaborator Author

cc @nfcampos this removes .transform from XMLOutputParser

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 25, 2024
This reverts commit 63b5890.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) March 25, 2024 21:32
@eyurtsev eyurtsev merged commit 56f4c54 into master Mar 25, 2024
95 checks passed
@eyurtsev eyurtsev deleted the eugene/xml_streaming_2 branch March 25, 2024 21:34
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Previous PR passed _parser attribute which apparently is not meant to be
used by user code and causes non deterministic failures on CI when
testing the transform and a transform methods. Reverting this change
temporarily.
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
Previous PR passed _parser attribute which apparently is not meant to be
used by user code and causes non deterministic failures on CI when
testing the transform and a transform methods. Reverting this change
temporarily.
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
Previous PR passed _parser attribute which apparently is not meant to be
used by user code and causes non deterministic failures on CI when
testing the transform and a transform methods. Reverting this change
temporarily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: openai Primarily related to OpenAI integrations size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants