Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: More flexible handling for entity names in vector store "HANA Cloud" #19523

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

MartinKolbAtWork
Copy link
Contributor

  • Description: Added support for lower-case and mixed-case names
    The names for tables and columns previouly had to be UPPER_CASE.
    With this enhancement, also lower_case and MixedCase are supported,

  • Issue: N/A

  • Dependencies: no new dependecies added

  • Twitter handle: @sapopensource

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 5:58pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: weaviate Primarily related to Weaviate vector store integration 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 25, 2024
The names for tables and columns previouly had to be UPPER_CASE.
With this enhancement, also lower_case and MixedCase are supported,
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 25, 2024
@baskaryan baskaryan merged commit e5bdb26 into langchain-ai:master Mar 25, 2024
59 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…tore "HANA Cloud" (langchain-ai#19523)

- **Description:** Added support for lower-case and mixed-case names
The names for tables and columns previouly had to be UPPER_CASE.
With this enhancement, also lower_case and MixedCase are supported,


  - **Issue:** N/A
  - **Dependencies:** no new dependecies added
  - **Twitter handle:** @sapopensource
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
…tore "HANA Cloud" (langchain-ai#19523)

- **Description:** Added support for lower-case and mixed-case names
The names for tables and columns previouly had to be UPPER_CASE.
With this enhancement, also lower_case and MixedCase are supported,


  - **Issue:** N/A
  - **Dependencies:** no new dependecies added
  - **Twitter handle:** @sapopensource
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…tore "HANA Cloud" (#19523)

- **Description:** Added support for lower-case and mixed-case names
The names for tables and columns previouly had to be UPPER_CASE.
With this enhancement, also lower_case and MixedCase are supported,


  - **Issue:** N/A
  - **Dependencies:** no new dependecies added
  - **Twitter handle:** @sapopensource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: weaviate Primarily related to Weaviate vector store integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants