Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: migrate bigdl-llm to ipex-llm #19518

Merged
merged 25 commits into from
Mar 28, 2024

Conversation

shane-huang
Copy link
Contributor

@shane-huang shane-huang commented Mar 25, 2024

Updated doc: docs/docs/integrations/llms/ipex_llm.ipynb
Updated test: libs/community/tests/integration_tests/llms/test_ipex_llm.py

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 25, 2024
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain 🛑 Canceled (Inspect) Mar 28, 2024 2:47am

@dosubot dosubot bot added the 🤖:refactor A large refactor of a feature(s) or restructuring of many files label Mar 25, 2024
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a redirect to docs/vercel.json to point from old url to new url

@@ -10,22 +10,22 @@
logger = logging.getLogger(__name__)


class BigdlLLM(LLM):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for backwards compatibility can we keep around a bigdl.py file and does

from langchain_community.llms.ipex_llm import IPEXLLM

BigdlLLM = IPEXLLM

that way existing code that uses this integration won't break

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I could not use BigdlLLM = IPEXLLM as the imports are different. Instead I inherite from IpexLLM and override necessary methods.

libs/community/langchain_community/llms/ipex_llm.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
@shane-huang shane-huang reopened this Mar 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 26, 2024
@shane-huang
Copy link
Contributor Author

can we add a redirect to docs/vercel.json to point from old url to new url

added the url redirection

@shane-huang
Copy link
Contributor Author

@baskaryan Please kindly let me know if there's anything else I need to change.

docs/vercel.json Outdated Show resolved Hide resolved
@baskaryan baskaryan merged commit ac1dd8a into langchain-ai:master Mar 28, 2024
59 of 60 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
- **Description**: `bigdl-llm` library has been renamed to
[`ipex-llm`](https://github.com/intel-analytics/ipex-llm). This PR
migrates the `bigdl-llm` integration to `ipex-llm` .
- **Issue**: N/A. The original PR of `bigdl-llm` is
langchain-ai#17953
- **Dependencies**: `ipex-llm` library
- **Contribution maintainer**: @shane-huang

Updated doc:   docs/docs/integrations/llms/ipex_llm.ipynb
Updated test:
libs/community/tests/integration_tests/llms/test_ipex_llm.py
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
- **Description**: `bigdl-llm` library has been renamed to
[`ipex-llm`](https://github.com/intel-analytics/ipex-llm). This PR
migrates the `bigdl-llm` integration to `ipex-llm` .
- **Issue**: N/A. The original PR of `bigdl-llm` is
#17953
- **Dependencies**: `ipex-llm` library
- **Contribution maintainer**: @shane-huang

Updated doc:   docs/docs/integrations/llms/ipex_llm.ipynb
Updated test:
libs/community/tests/integration_tests/llms/test_ipex_llm.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants