Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[runnables]: docstring for class runnable, method with_listeners() #19515

Merged
merged 1 commit into from
Mar 25, 2024
Merged

core[runnables]: docstring for class runnable, method with_listeners() #19515

merged 1 commit into from
Mar 25, 2024

Conversation

sepiatone
Copy link
Contributor

Description: Docstring for method with_listerners() of class Runnable
Issue: Add in code documentation to core Runnable methods #18804
Dependencies: None

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 25, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 2:50pm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Mar 25, 2024
@sepiatone
Copy link
Contributor Author

@ccurme @eyurtsev Please review

eyurtsev
eyurtsev approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect amazing

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 25, 2024
@eyurtsev eyurtsev merged commit aa68fd7 into langchain-ai:master Mar 25, 2024
95 checks passed
@sepiatone sepiatone deleted the docstring_runnables_with_listeners branch March 26, 2024 05:58
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@sepiatone @gkorland
core[runnables]: docstring for class runnable, method with_listeners() (
1068ff3 
langchain-ai#19515)

**Description:** Docstring for method with_listerners() of class
Runnable
**Issue:** [Add in code documentation to core Runnable methods
langchain-ai#18804](langchain-ai#18804)
**Dependencies:** None
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
@sepiatone @chrispy-snps
core[runnables]: docstring for class runnable, method with_listeners() (
be0b9ad 
langchain-ai#19515)

**Description:** Docstring for method with_listerners() of class
Runnable
**Issue:** [Add in code documentation to core Runnable methods
langchain-ai#18804](langchain-ai#18804)
**Dependencies:** None
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@sepiatone @hinthornw
core[runnables]: docstring for class runnable, method with_listeners() (
c9860ec 
#19515)

**Description:** Docstring for method with_listerners() of class
Runnable
**Issue:** [Add in code documentation to core Runnable methods
#18804](#18804)
**Dependencies:** None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepiatone @eyurtsev