-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add len() implementation to Chroma #19419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ccurme
approved these changes
Mar 26, 2024
Thanks! |
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
Thank you for contributing to LangChain! - [x] **Add len() implementation to Chroma**: "package: community" - [x] **PR message**: - **Description:** add an implementation of the __len__() method for the Chroma vectostore, for convenience. - **Issue:** no exposed method to know the size of a Chroma vectorstore - **Dependencies:** None - **Twitter handle:** lowrank_adrian - [x] **Add tests and docs** - [x] **Lint and test** --------- Co-authored-by: Bagatur <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
Thank you for contributing to LangChain! - [x] **Add len() implementation to Chroma**: "package: community" - [x] **PR message**: - **Description:** add an implementation of the __len__() method for the Chroma vectostore, for convenience. - **Issue:** no exposed method to know the size of a Chroma vectorstore - **Dependencies:** None - **Twitter handle:** lowrank_adrian - [x] **Add tests and docs** - [x] **Lint and test** --------- Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔌: chroma
Primarily related to ChromaDB integrations
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XS
This PR changes 0-9 lines, ignoring generated files.
Ɑ: vector store
Related to vector store module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Add len() implementation to Chroma: "package: community"
PR message:
Add tests and docs
Lint and test