Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

milvus will autoflush, manual flush is slowly #19300

Merged
merged 4 commits into from
Mar 26, 2024
Merged

milvus will autoflush, manual flush is slowly #19300

merged 4 commits into from
Mar 26, 2024

Conversation

JamesBonddu
Copy link
Contributor

@JamesBonddu JamesBonddu commented Mar 20, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 0:23am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: milvus Primarily related to Milvus vector store integration 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 20, 2024
@JamesBonddu JamesBonddu mentioned this pull request Mar 20, 2024
Closed
1 task
@xiaofan-luan
Copy link

lgtm
There is no need to call flush since data will be seen without auto flush

@JamesBonddu
Copy link
Contributor Author

@baskaryan please merge it

@baskaryan baskaryan enabled auto-merge (squash) March 26, 2024 00:24
@baskaryan baskaryan merged commit 6e09028 into langchain-ai:master Mar 26, 2024
59 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@JamesBonddu @baskaryan @gkorland
community[patch]: milvus will autoflush, manual flush is slowly (lang…
16582f9 
…chain-ai#19300)

reference:


https://milvus.io/docs/configure_quota_limits.md#quotaAndLimitsflushRateenabled

milvus-io/milvus#31407

Co-authored-by: Bagatur <[email protected]>
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
@JamesBonddu @baskaryan @chrispy-snps
community[patch]: milvus will autoflush, manual flush is slowly (lang…
8ad86dd 
…chain-ai#19300)

reference:


https://milvus.io/docs/configure_quota_limits.md#quotaAndLimitsflushRateenabled

milvus-io/milvus#31407

Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@JamesBonddu @baskaryan @hinthornw
community[patch]: milvus will autoflush, manual flush is slowly (#19300)
a80a4bc 
reference:


https://milvus.io/docs/configure_quota_limits.md#quotaAndLimitsflushRateenabled

milvus-io/milvus#31407

Co-authored-by: Bagatur <[email protected]>
@JamesBonddu JamesBonddu mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases 🔌: milvus Primarily related to Milvus vector store integration size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesBonddu @xiaofan-luan @baskaryan