Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Fix the bug that Chroma does not specify embedding_function #19277

Merged
merged 3 commits into from
Mar 27, 2024
Merged

community: Fix the bug that Chroma does not specify embedding_function #19277

merged 3 commits into from
Mar 27, 2024

Conversation

liugddx
Copy link
Contributor

@liugddx liugddx commented Mar 19, 2024

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 1:41am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: chroma Primarily related to ChromaDB integrations 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 19, 2024
@eyurtsev eyurtsev self-assigned this Mar 19, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 20, 2024
@eyurtsev
Copy link
Collaborator

Will merge once on my computer

@baskaryan
Copy link
Collaborator

cc @jeffchuber

@liugddx
Copy link
Contributor Author

liugddx commented Mar 27, 2024

It runs fine on my mac

@eyurtsev eyurtsev merged commit 7042934 into langchain-ai:master Mar 27, 2024
59 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@liugddx @gkorland
community[patch]: Fix the bug that Chroma does not specify `embedding…
02ecfe8 
…_function` (langchain-ai#19277)

- **Issue:** close langchain-ai#18291
- @baskaryan, @eyurtsev PTAL
baskaryan added a commit that referenced this pull request Apr 1, 2024
@baskaryan
Revert "community[patch]: Fix the bug that Chroma does not specify `e…
bbf6dad 
…mbedding_function` (#19277)"

This reverts commit 7042934.
@baskaryan baskaryan mentioned this pull request Apr 1, 2024
Merged
baskaryan added a commit that referenced this pull request Apr 1, 2024
@baskaryan
community[patch]: Revert " Fix the bug that Chroma does not specify `…
d62e84c 
…e… (#19866)

…mbedding_function` (#19277)"

This reverts commit 7042934.

Fixes #19848
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@liugddx @hinthornw
community[patch]: Fix the bug that Chroma does not specify `embedding…
d6b8be6 
…_function` (#19277)

- **Issue:** close #18291
- @baskaryan, @eyurtsev PTAL
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@baskaryan @hinthornw
community[patch]: Revert " Fix the bug that Chroma does not specify `…
4228d95 
…e… (#19866)

…mbedding_function` (#19277)"

This reverts commit 7042934.

Fixes #19848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🔌: chroma Primarily related to ChromaDB integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to use Chroma vectorstore with default embedding_function results in an error
3 participants
@liugddx @eyurtsev @baskaryan