community: fix yuan2 errors in LLMs #19004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cauwulixuan
commented
Mar 13, 2024
cauwulixuan
commented
- fix yuan2 errors while invoke Yuan2.
- update tests.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:S
hwchase17
reviewed
Mar 19, 2024
| "top_p and top_k cannot be set simultaneously. " | ||
| "set top_k to 0 instead..." | ||
| ) | ||
| self.top_k = 0 |
There was a problem hiding this comment.
this should be checked during initialization
There was a problem hiding this comment.
Sure, thanks for your advice. PTAL;)
|
It seems like the CI progress is failed with some network error.. Could you trigger it again? @hwchase17 |
|
Well, all checks have passed. @hwchase17 PTAL, thanks. |
baskaryan
approved these changes
Mar 28, 2024
dosubot
bot
added
the
lgtm
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
1. fix yuan2 errors while invoke Yuan2. 2. update tests.
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
1. fix yuan2 errors while invoke Yuan2. 2. update tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.