Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Optimize Makefile for Better Usability and Maintenance #18859

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Mar 10, 2024

  • PR title: "package: description"

    • The "package" should reflect the area of the project your changes impact, such as langchain, community, core, experimental, etc. Use "docs: ..." for documentation updates, "templates: ..." for changes to templates, and "infra: ..." for continuous integration and infrastructure changes.
    • Example: "community: add foobar LLM integration"
  • PR message: Delete this entire checklist and replace it with the following details:

    • Description: A clear and concise description of what the changes are and the rationale behind them.
    • Issue: Mention the issue number this PR addresses, if applicable. Use "Fixes #issue_number" to automatically link and close the issue when the PR is merged.
    • Dependencies: List any new dependencies introduced by this change. Please highlight if any dependencies need special consideration during review.
    • Twitter handle: Include your Twitter handle if you'd like to be mentioned when your PR is highlighted on our social media channels.
  • Add tests and documentation: If introducing a new feature or integration:

    1. Add unit tests that do not rely on network access to ensure reliability and facilitate quicker integration tests.
    2. Provide an example notebook or documentation in the docs/docs/integrations directory to demonstrate how to use the new feature or integration.
  • Lint and test your changes: Before submitting, please run make format, make lint, and make test from the root directory of the modified package(s) to ensure your changes adhere to our coding standards and pass all tests. Refer to our contribution guidelines for more detailed instructions: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Ensure that optional dependencies are only imported within function calls to avoid unnecessary import errors for users who haven't installed these dependencies.
  • Avoid adding new dependencies to the pyproject.toml files (including optional ones) unless they are crucial for unit tests or the core functionality of your contribution.
  • Aim to keep your changes confined to a single package whenever possible to simplify the review process and minimize potential conflicts.
  • Strive for backward compatibility with your changes to prevent breaking existing functionality for users.
  • When contributing to the community package, ensure you do not inadvertently re-import functionality already available in langchain.

If your PR has not been reviewed within a few days, feel free to @-mention one of our maintainers for assistance: baskaryan, efriis, eyurtsev, hwchase17. We appreciate your patience and are excited to review your contribution to the LangChain community!

Previous screenshots:

image

Current screenshot:
image

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 10, 2024
Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2024 2:45am

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Mar 10, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 28, 2024
@baskaryan baskaryan merged commit 26eed70 into langchain-ai:master Mar 28, 2024
10 checks passed
@cubxxw cubxxw deleted the patch-1 branch March 28, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants